Add printk when in data abort #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Iwanicki <[email protected]>
m-iwanicki
force-pushed
the
backport-85b8353
branch
from
96bbc53 to
a72abbc
Compare
m-iwanicki
changed the title
DaniilKl
reviewed
Jun 25, 2025
| @@ -56,6 +56,9 @@ void aborts_data_lower(uint64_t iss, uint64_t far, uint64_t il) | |||
|
|
|||
| vaddr_t addr = far; | |||
| emul_handler_t handler = vm_emul_get_mem(cpu.vcpu->vm, addr); | |||
| if (addr <= 0xff000000) { | |||
There was a problem hiding this comment.
I suppose I have found the reason here crosscon/CROSSCON-Hypervisor-and-TEE-Isolation-Demos#32 (comment):
You should add some prints there, possibly with an if condition to only print on addresses you know are memory to prevent gic accesses from cluttering the output.
Trying to map this if on the configuration you are using.
There was a problem hiding this comment.
Maybe I understood wrong but gic starts at around 0xff*:
and I thought that meant I should print only when address doesn't belong to range used by gic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crosscon/CROSSCON-Hypervisor@85b8353